[PATCH] D70661: [MC] Produce proper section relative relocations for COFF in .debug_frame
Martin Storsjö via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Nov 26 12:31:37 PST 2019
mstorsjo added a comment.
To clarify this change (it's rather obscure in this plain form even though the change in principle is trivial); the third parameter to `Streamer.EmitSymbolValue` is `bool IsSectionRelative = false`. For ELF, these debug sections are mapped to address zero, so a normal, absolute address relocation works just fine, but COFF needs a section relative relocation, and COFF is the only target where `needsDwarfSectionOffsetDirective()` returns true.. This matches how `EmitSymbolValue` is called elsewhere in the same source file.
I'll add something to this effect in the commit message as well.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70661/new/
https://reviews.llvm.org/D70661
More information about the llvm-commits
mailing list