[PATCH] D70673: [AArch64] Fix over-eager fusing of integer NEON MUL/ADD
Dave Green via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Nov 26 11:45:22 PST 2019
dmgreen added a comment.
Is the plan to add the indexed variants too? To treat them in the same way.
================
Comment at: llvm/include/llvm/CodeGen/MachineCombinerPattern.h:42
+ // NEON integers vectors
+ VMULADDv8i8_OP1,
+ VMULADDv8i8_OP2,
----------------
Do these need V's on the front? The type is already in the name.
================
Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.cpp:4141
+ unsigned IdxMulOpd, unsigned MaddOpc, const TargetRegisterClass *RC,
+ const Register *ReplacedAddend = nullptr) {
+ return genFusedMultiply(MF, MRI, TII, Root, InsInstrs, IdxMulOpd, MaddOpc, RC,
----------------
Is ReplacedAddend ever not nullptr?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70673/new/
https://reviews.llvm.org/D70673
More information about the llvm-commits
mailing list