[PATCH] D70660: Add initial tests for update_{llc,cc}_test_checks.py

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/test/tools/UpdateTestChecks/lit.local.cfg:18
+    config.substitutions.append(
+        ('%' + name, '\'%s\' %s %s' % (python_exe, script_path, extra_args)))
+
----------------
Use " when nested ' is used to reduce escaping.


================
Comment at: llvm/test/tools/UpdateTestChecks/update_cc_tests/Inputs/mangled_names.c:12
+}
+
+
----------------
Remove trailing empty lines.


================
Comment at: llvm/test/tools/UpdateTestChecks/update_cc_tests/mangled_names.test:54
+# GENERATED-EMPTY:
+
----------------
Remove trailing empty line.


================
Comment at: llvm/test/tools/UpdateTestChecks/update_llc_tests/basic.test:4
+
+# RUN: cp -f %S/Inputs/basic.ll %t.ll
+# RUN: %update_llc_test_checks %t.ll
----------------
Delete `-f`. It is not needed.

I get another idea. We can probably use `sed` to delete `#` lines in `%s` and feed that to `%update_llc_test_checks`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70660/new/

https://reviews.llvm.org/D70660