[PATCH] D69578: [AIX] Add support for lowering int, float and double formal arguments.

[Zarko Todorovski via Phabricator via llvm-commits]

ZarkoCA marked 2 inline comments as done.
ZarkoCA added a comment.

In D69578#1760258 <https://reviews.llvm.org/D69578#1760258>, @sfertile wrote:

> Only a couple minor comments. Otherwise LGTM.


Thank you!



================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:6828
+  MachineFunction &MF = DAG.getMachineFunction();
+  PPCFunctionInfo *FuncInfo = MF.getInfo<PPCFunctionInfo>();
+  assert((CallConv == CallingConv::C || CallConv == CallingConv::Cold ||
----------------
sfertile wrote:
> Minor nit: This should be defined just before it use (`FuncInfo->setMinReservedArea(MinReservedArea);)`
Moved this and the MF definition to just before they are used.  MF is moved to line 6850: 

```
 MachineFunction &MF = DAG.getMachineFunction();
  CCState CCInfo(CallConv, isVarArg, MF, ArgLocs, *DAG.getContext());
```


================
Comment at: llvm/test/CodeGen/PowerPC/aix_cc_abi.ll:130
+
+; 32BIT:       liveins:
+; 32BIT-NEXT:  - { reg: '$r3', virtual-reg: '' }
----------------
sfertile wrote:
> Looks good. We should also have the same function but with a zeroext arg attribute and show that we don't end up with a clear instruction in this case. The new function doesn't need to be called. 
Thanks added it below as `@test_i1zext()`



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69578/new/

https://reviews.llvm.org/D69578