[PATCH] D70717: [llvm-readobj] - Always print "Predecessors" for version definition sections.
George Rimar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Nov 26 07:11:52 PST 2019
grimar created this revision.
grimar added reviewers: jhenderson, MaskRay, rupprecht, ruiu.
Herald added subscribers: seiya, arichardson, emaste.
Herald added a reviewer: espindola.
Herald added a project: LLVM.
This is a follow-up discussed in D70495 <https://reviews.llvm.org/D70495> thread.
The current logic is unusual for llvm-readobj. It doesn't print predecessors
list when it is empty. This is not good for machine parsers.
D70495 <https://reviews.llvm.org/D70495> had to add this condition during refactroring to reduce amount of changes,
in tests, because the original code also had a similar logic.
Now seems it is time to get rid of it. This patch does it.
https://reviews.llvm.org/D70717
Files:
lld/test/ELF/verdef-defaultver.s
lld/test/ELF/verdef-dependency.s
lld/test/ELF/verdef.s
llvm/test/tools/llvm-readobj/elf-versioninfo.test
llvm/test/tools/yaml2obj/ELF/verdef-section.yaml
llvm/tools/llvm-readobj/ELFDumper.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D70717.231063.patch
Type: text/x-patch
Size: 5633 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191126/beff58ff/attachment.bin>
More information about the llvm-commits
mailing list