[PATCH] D70665: [llvm-readobj] - Implement --elf-dependent-libs flag.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 26 01:29:28 PST 2019


grimar added inline comments.


================
Comment at: llvm/test/tools/llvm-readobj/elf-dependent-libraries.test:11
+# CHECK:      DependentLibs [
+# CHECK-NEXT:   Entries: [foo, bar, foo]
+# CHECK-NEXT: ]
----------------
jhenderson wrote:
> I don't see the need for the `Entries:` list. Can't you just print them as:
> ```
> DependentLibs [
>   foo,
>   bar,
>   foo
> ]
> ```
Done.
(Without a comma. It seems to be excessive to have it here + scoped printer's `printString()` does not print, I think we should not add it manually).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70665/new/

https://reviews.llvm.org/D70665





More information about the llvm-commits mailing list