[PATCH] D68857: [X86] Add strict fp support for operations of X87 instructions

LiuChen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 25 21:00:52 PST 2019


LiuChen3 marked an inline comment as done.
LiuChen3 added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ISelDAGToDAG.cpp:5228
+    if (!Subtarget->hasSSE1() && Subtarget->hasX87())
+      break;
   case ISD::STRICT_FP_TO_SINT:
----------------
craig.topper wrote:
> Need an LLVM_FALLTHROUGH marker here
I think there is still some problems here, I'll work on it


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68857/new/

https://reviews.llvm.org/D68857





More information about the llvm-commits mailing list