[PATCH] D70593: [LCSSA] Don't use VH callbacks to invalidate SCEV when creating LCSSA phis

Daniil Suchkov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 25 20:47:47 PST 2019


DaniilSuchkov added a comment.

In D70593#1759353 <https://reviews.llvm.org/D70593#1759353>, @efriedma wrote:

> Are the changes to loop unswitch supposed to be in this patch?


Yes. I knew it won't be obvious, so I left an inline comment:

> This change is required to preserve current behavior in cases when it's valid: sometimes invalidation of SCEV through VH actually worked as intended.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70593/new/

https://reviews.llvm.org/D70593





More information about the llvm-commits mailing list