[PATCH] D70655: [AutoFDO] Top-down Inlining for specialization with context-sensitive profile

[Wenlei He via Phabricator via llvm-commits]

wenlei marked 2 inline comments as done.
wenlei added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/SampleProfile.cpp:429-430
 
+  // Order list that dictates annotation and inlining order from sample loader
+  std::vector<Function *> FunctionOrderList;
+
----------------
wmi wrote:
> If the buildFunctionOrder call is moved to runOnModule, we don't need the field and buildFunctionOrder can return a function order vector.
good point, thanks for the suggestion. I moved `buildFunctionOrder` into `runOnModule`, and also moved `!isDeclaration` check into `buildFunctionOrder`.


================
Comment at: llvm/test/Transforms/SampleProfile/inline-topdown.ll:18
+  store i32 %y, i32* %y.addr, align 4
+  %0 = load i32, i32* %x.addr, align 4, !dbg !11
+  %1 = load i32, i32* %y.addr, align 4, !dbg !11
----------------
wmi wrote:
> rename the variable using opt -instnamer.
done.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70655/new/

https://reviews.llvm.org/D70655