[PATCH] D70698: [CodeGen] Fix hashing for RegMask operands.

[Eli Friedman via Phabricator via llvm-commits]

efriedma created this revision.
efriedma added a reviewer: arsenm.
Herald added subscribers: hiraditya, wdng.
Herald added a project: LLVM.

The code was hashing a pointer to the mask, not the mask itself.

The critical change here is the change to hash_value in MachineOperand.cpp; the other changes are just to pass around the size of the mask.

I'm not sure if this fixes any visible issues in the places hashing is currently used; this was found by inspection while looking into D61975 <https://reviews.llvm.org/D61975>.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D70698

Files:
  llvm/include/llvm/CodeGen/MachineInstrBuilder.h
  llvm/include/llvm/CodeGen/MachineOperand.h
  llvm/lib/CodeGen/MIRParser/MIParser.cpp
  llvm/lib/CodeGen/MachineOperand.cpp
  llvm/lib/CodeGen/RegUsageInfoPropagate.cpp
  llvm/lib/CodeGen/SelectionDAG/FastISel.cpp
  llvm/lib/CodeGen/StackMapLivenessAnalysis.cpp
  llvm/unittests/CodeGen/MachineOperandTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D70698.230974.patch
Type: text/x-patch
Size: 11942 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191125/eafabe02/attachment.bin>