[PATCH] D69914: [LVI] Normalize pointer behavior

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 25 14:37:50 PST 2019


nikic added a comment.

I'll rebase this over D70376 <https://reviews.llvm.org/D70376> once that lands, which should hopefully fix the python compilation issue. To provide some context, we were not properly invalidating elements in the overdefined value cache if they are deleted, which might result in incorrect "overdefined" result if something later happens to be allocated at the same location. This just causes non-determinism, because "overdefined" is a conservative assumption. However, this patch introduces a second cache that uses the same structure as the overdefined cache, and here missing the invalidation may result in a miscompile instead.

I'm traveling right now, so will probably only get around to this next week.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69914/new/

https://reviews.llvm.org/D69914





More information about the llvm-commits mailing list