[PATCH] D70126: [PowerPC] Refactor FinishCall

[Xiangling Liao via Phabricator via llvm-commits]

Xiangling_L added a comment.

Since this is a NFC patch, does it make sense to add `NFC` on patch title?



================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:5029
+  // need to jump to the local entry point (see rL211174).
+  if (!Subtarget.usesFunctionDescriptors() && !Subtarget.isELFv2ABI() &&
+      isBLACompatibleAddress(Callee, DAG))
----------------
It looks like `!Subtarget.usesFunctionDescriptors() && !Subtarget.isELFv2ABI() ` eqauls to `isDarwin() || is32ELFv1ABI()`, but AFAIK Darwin is abondoned, and there is no 32bit ELFv1 ABI(Correct me if I am wrong), can we skip this query?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70126/new/

https://reviews.llvm.org/D70126