[PATCH] D70655: [AutoFDO] Top-down Inlining for specialization with context-sensitive profile

[Wenlei He via Phabricator via llvm-commits]

wenlei added a comment.

Thanks for the discussions and code review. I'll address the comments later, but wanted to answer this one first.

> Do you see how much impact on performance and code size by changing it? I will do some evaluation on my side.

I ran it with MySQL linkbench (https://github.com/facebookarchive/linkbench), and it showed ~0.5% performance win and slight code size increase (<1%) with D70653 <https://reviews.llvm.org/D70653>, this patch, and another one combined together. (the other one let inline replay also inline small functions if CGSCC inliner will inline them eventually. I'll upstream that one too).

I haven't tried to measure the breakdown yet, but I think the profile merge and top-down inline change should be the most important ones. I plan to play more with each individual changes, and I'm also interested in what you see from your workload. (I'm putting these changes each under a switch so it's easier for all of us to measure and tune).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70655/new/

https://reviews.llvm.org/D70655