[PATCH] D70654: [LegalizeTypes][FPEnv][X86] Add initial support for softening strict fp nodes

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 25 12:46:34 PST 2019


efriedma added a comment.

Could you split the refactoring to introduce SoftenFloatRes_Unary and SoftenFloatRes_Binary into a separate patch?



================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeFloatTypes.cpp:878
+    ReplaceValueWith(SDValue(N, 0), Tmp.first);
+    return SDValue();
+  }
----------------
This is different from the other operations?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70654/new/

https://reviews.llvm.org/D70654





More information about the llvm-commits mailing list