[PATCH] D70669: [AArch64TTI] Do not return TCC_Free for all unknown intrinsics.

Mon Nov 25 12:09:36 PST 2019

fhahn marked an inline comment as done.
fhahn added inline comments.

================
Comment at: llvm/test/Transforms/ConstantHoisting/AArch64/const-hoist-intrinsics.ll:1
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
+; RUN: opt -mtriple=arm64-darwin-unknown -S -consthoist < %s | FileCheck %s
----------------
SjoerdMeijer wrote:
> I thought tests for  instruction costs are checked with these kind of opt tests:
> 
>     opt < %s  -cost-model -analyze -cost-kind=...
> 
> is that not a better/more direct way of testing this?
I think the various cost-kinds just focus just on the instruction, not the arguments. So there seems to be no way to get it to print the cost of materializing the immediate.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70669/new/

https://reviews.llvm.org/D70669