[PATCH] D70658: [LLD][ELF] - Make compression level be dependent on -On.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 25 10:07:12 PST 2019


MaskRay added a comment.

https://bugs.llvm.org/show_bug.cgi?id=44089

> So, I think we should use level 1 for the default and level 6 for -O2, and I don't think we need a new option to specify some other value as a compression level.



  -O0 => level 1
  -O1 => level 1
  -O2 => level 6

makes sense.

We use `-Wl,--compress-debug-sections=zlib` and default `-Wl,-O1` for asan builds, so some users may observe size increases (due to: zlib level 6 -> zlib level 1). I will try accommodating the targets not to rely on the size, but I may request for a new option for compression level (@ruiu) if fixing them is not feasible. (I genuinely want to keep the configuration simple, so not having an additional option is also my preference.)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70658/new/

https://reviews.llvm.org/D70658





More information about the llvm-commits mailing list