[PATCH] D70660: Add initial tests for update_{llc,cc}_test_checks.py

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 25 09:47:36 PST 2019


jdoerfert added a comment.

Thanks for working on this.

Two general questions, but it generally looks fine to me:

Why do we have the extra input folders that contain all files? 
Could you add the same for the `opt` script?



================
Comment at: llvm/test/tools/UpdateTestChecks/update_cc_tests/mangled_names.test:31
+# GENERATED-NEXT: }
+# GENERATED-EMPTY:
+# GENERATED-NEXT: // A function with a mangled name
----------------
Are these (EMPTY lines) auto generated?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70660/new/

https://reviews.llvm.org/D70660





More information about the llvm-commits mailing list