[PATCH] D70637: [ELF][AArch64] Support R_AARCH64_{CALL26,JUMP26} range extension thunks with addends
Peter Smith via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Nov 25 09:10:48 PST 2019
peter.smith added a comment.
I'm comfortable with the detailed code-changes. I initially thought that using a nested pair might make the code too difficult to read, but it is clear at the construction of the pair which field is which. I'd definitely want to avoid referring the elements of the pair with first.first or first.second, but as we only use it as a key it doesn't matter.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70637/new/
https://reviews.llvm.org/D70637
More information about the llvm-commits
mailing list