[PATCH] D70665: [llvm-readobj] - Implement --elf-dependent-libs flag.
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Nov 25 06:57:46 PST 2019
jhenderson added a comment.
The llvm-readobj doc needs updating.
================
Comment at: llvm/test/tools/llvm-readobj/elf-dependent-libraries.test:11
+# CHECK: DependentLibs [
+# CHECK-NEXT: Entries: [foo, bar, foo]
+# CHECK-NEXT: ]
----------------
I don't see the need for the `Entries:` list. Can't you just print them as:
```
DependentLibs [
foo,
bar,
foo
]
```
================
Comment at: llvm/test/tools/llvm-readobj/elf-dependent-libraries.test:45
+Sections:
+## Case 1: test we report a warning when have not null-terminated section.
+ - Name: .deplibs.nonul
----------------
when have not null-terminated -> for a non-null-terminated
================
Comment at: llvm/test/tools/llvm-readobj/elf-dependent-libraries.test:57
+ Content: ""
+## Case 4: test we can dump aall entries from a valid section that has more than one entry.
+ - Name: .deplibs.multiple
----------------
aall -> all
================
Comment at: llvm/test/tools/llvm-readobj/elf-dependent-libraries.test:61
+ Libraries: [ bar, xxx ]
+## Case 5: test we report a warning when unable to get the content.
+ - Name: .deplibs.broken.shoffset
----------------
when unable to get the content -> when the section offset is invalid
================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:6073
+ auto Warn = [this](unsigned SecNdx, StringRef Msg) {
+ reportWarning(createError("SHT_LLVM_DEPENDENT_LIBRARIES section at index " +
+ Twine(SecNdx) + " is broken: " + Msg),
----------------
reportUniqueWarning?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70665/new/
https://reviews.llvm.org/D70665
More information about the llvm-commits
mailing list