[PATCH] D67258: Out-of-tree machine IR passes

[Adrien Guinet via Phabricator via llvm-commits]

aguinet marked 2 inline comments as done.
aguinet added inline comments.


================
Comment at: examples/OutOfTreeMIR/FunctionPass/CMakeLists.txt:1
+add_llvm_library(MIRFunctionPass MODULE
+  FunctionPass.cpp
----------------
serge-sans-paille wrote:
> based on ../lib/Transforms/Hello/CMakeLists.txt, you could pass BUILDTREE_ONLY as an extra flag
Indeed. Will add it in the next patch!


================
Comment at: lib/CodeGen/TargetPassConfig.cpp:229
+}
+
+
----------------
serge-sans-paille wrote:
> This code is very similar to the legacy pass manager machinery, which is very different from the new PM one.
> 
> Adding the feature here totally makes sense to me, but I'm unsure if the MIR passes management is going to be reworked just like IR passes was, @chandlerc ?
That's a good question :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67258/new/

https://reviews.llvm.org/D67258