[PATCH] D70501: [SystemZ] Don't build a PPA instruction with an immediate 0

Ulrich Weigand via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 25 04:23:34 PST 2019


uweigand added a comment.

In D70501#1758612 <https://reviews.llvm.org/D70501#1758612>, @jonpa wrote:

> This builds a register operand with NoReg, which then makes the IR correct while it is also necessary to handle this in the AsmPrinter since otherwise the call to get the register name will fail.


Can't we handle NoRegister generically in the AsmPrinter somewhere without tying that to the specific PPA opcode?  Maybe we'll want to use it elsewhere as well ...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70501/new/

https://reviews.llvm.org/D70501





More information about the llvm-commits mailing list