[PATCH] D67258: Out-of-tree machine IR passes

[serge via Phabricator via llvm-commits]

serge-sans-paille added a subscriber: chandlerc.
serge-sans-paille added inline comments.


================
Comment at: examples/CMakeLists.txt:10
 
+if (BUILD_SHARED_LIBS OR LLVM_LINK_LLVM_DYLIB)
+  add_subdirectory(OutOfTreeMIR)
----------------
Why don't you always build it?


================
Comment at: examples/OutOfTreeMIR/FunctionPass/CMakeLists.txt:1
+add_llvm_library(MIRFunctionPass MODULE
+  FunctionPass.cpp
----------------
based on ../lib/Transforms/Hello/CMakeLists.txt, you could pass BUILDTREE_ONLY as an extra flag


================
Comment at: lib/CodeGen/TargetPassConfig.cpp:229
+}
+
+
----------------
This code is very similar to the legacy pass manager machinery, which is very different from the new PM one.

Adding the feature here totally makes sense to me, but I'm unsure if the MIR passes management is going to be reworked just like IR passes was, @chandlerc ?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67258/new/

https://reviews.llvm.org/D67258