[PATCH] D70587: [SLP] Enhance SLPVectorizer to vectorize different combinations of aggregates

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added a comment.

A couple of minors - does anyone else have any comments?



================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:637
   /// \returns number of elements in vector if isomorphism exists, 0 otherwise.
   unsigned canMapToVector(Type *T, const DataLayout &DL) const;
 
----------------
Update the description?


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:6963
+                                            IE->getType(),
+                                            CI->getZExtValue());
+      }
----------------
If the insertion index isn't constant we should call getVectorInstrCost with a ~0/-1 value


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70587/new/

https://reviews.llvm.org/D70587