[PATCH] D70598: [yaml2obj/obj2yaml] - Add support for SHT_LLVM_DEPENDENT_LIBRARIES sections.

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, with a couple of nits.



================
Comment at: llvm/test/tools/obj2yaml/llvm-deplibs-section.yaml:27
+Sections:
+## Case 1: test we use "Libraries" to dump a valid section with a null-terminated string.
+  - Name:      .deplibs.single
----------------
to dump -> when dumping 

also for case 3 and 4.

(I think that more clearly says that the interesting bit is "Libraries" in the output).


================
Comment at: llvm/test/tools/obj2yaml/llvm-deplibs-section.yaml:31
+    Libraries: [ foo ]
+## Case 2: the same, but section now has multiple strings.
+  - Name:      .deplibs.multiple
----------------
but section now has -> but the section has


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70598/new/

https://reviews.llvm.org/D70598