[PATCH] D68857: [X86] Add strict fp support for operations of X87 instructions

Mon Nov 25 00:05:25 PST 2019

LiuChen3 added a comment.

In D68857#1756615 <https://reviews.llvm.org/D68857#1756615>, @RKSimon wrote:

> In D68857#1756222 <https://reviews.llvm.org/D68857#1756222>, @LiuChen3 wrote:
>
> > In D68857#1755370 <https://reviews.llvm.org/D68857#1755370>, @RKSimon wrote:
> >
> > > The new tests and test renames can be done as an NFC commit - then please rebase this patch
> >
> >
> > Sorry, I am not clear of what you mean. Do you mean I should make a new patch to add these tests?  The tests in my current patch is not just  renamed, but also doing functional test. I think it's better to keep them together.
> >  And I think make a new patch to rename the tests is reasonable.
>
>
> I've updated/added the tests in rG5aaca2355ec2 <https://reviews.llvm.org/rG5aaca2355ec2ba043c9b1ba2be9674b128dfa718> (matching Craig's changes in rG0cc12b8a8310 <https://reviews.llvm.org/rG0cc12b8a83100027b16e1dc5cec079ba437ca3e0>) - the changes were an NFC cleanup and don't require a new patch. Please can you now rebase?

I have rebase. Thanks.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68857/new/

https://reviews.llvm.org/D68857