[PATCH] D70597: [PHIEliminate] skip dbg instruction when LowerPHINode

[Bjorn Pettersson via Phabricator via llvm-commits]

bjope added inline comments.


================
Comment at: llvm/test/CodeGen/X86/phi-node-elimination-dbg-invariant.mir:45
+    %1:gr32 = PHI %0:gr32, %bb.0, %2:gr32, %bb.1
+    DBG_VALUE
+    EH_LABEL 0
----------------
What if this DBG_VALUE is using %1. I think that could be an interesting test case to add as well.
If we PHI is lowered into a copy that comes after the EH_LABEL, then we probably need to move the DBG_VALUE to make sure it is after the label, to make this correct.

What happens to the DBG_VALUE with the current solution? (it is not shown in the CHECK:s, is it still present before the EH_LABEL?)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70597/new/

https://reviews.llvm.org/D70597