[PATCH] D70620: [CommandLine] Add callbacks to Options

[Don Hinton via Phabricator via llvm-commits]

hintonda marked an inline comment as done.
hintonda added inline comments.


================
Comment at: llvm/include/llvm/Support/CommandLine.h:1364
+
+  // setImplied is only supported for enabling boolean options.
+  template <typename T, typename std::enable_if<std::is_same<T, bool>::value,
----------------
hintonda wrote:
> serge-sans-paille wrote:
> > Why limiting that top boolean? You could pass a callback that does extra processing based on the set value?
> > 
> That's a great idea, and if we had a default method, we could support implied options via the same mechanism.  
> Let me see what I can come up with.
@serge-sans-paille, I took your advice and added callbacks, which eliminated the need for `cl::implied`, so I removed it.  Thanks again...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70620/new/

https://reviews.llvm.org/D70620