[PATCH] D70639: [IR] Take const references to LLVMContext

[Brian Gesiak via Phabricator via llvm-commits]

modocache abandoned this revision.
modocache added a subscriber: mehdi_amini.
modocache added a comment.

I spoke with @mehdi_amini in the (experimental?) LLVM Discord and his take was that this leaks internal implementation details of `LLVMContext`: while accessing these types can in fact use `const` because `LLVMContext` constructs the types eagerly (as a performance optimization), there's no reason `LLVMContext` //must// do so eagerly. Modifying these to take a `const` reference inhibits the ability to change `LLVMContext` to lazily construct these types, and so this isn't a desirable change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70639/new/

https://reviews.llvm.org/D70639