[PATCH] D69930: [OpenMP] Introduce the OpenMPOpt transformation pass

Sat Nov 23 18:22:53 PST 2019

jdoerfert added a subscriber: chandlerc.
jdoerfert added a comment.

In D69930#1757865 <https://reviews.llvm.org/D69930#1757865>, @lebedev.ri wrote:

> I'm really not the best person to review this :/

No one (I ask) seems to be. At some point, I argue, it should be enough that it looks good to multiple "non-experts". We can always revert it.
Though, I will make it easier, see below.

> It seems generally within what'd expect, but i'm not really familiar with SCC passes.

I will add a call graph helper soon, given that I think I figured out how to use both of them.
I hope @chandlerc or someone else familiar with both call graphs (for old & new pass manager) will review them.
Assuming that works, there is little SCC related left that is not "provided" by this helper.

> Some thoughts:

I'll adjust according to your comments shortly.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69930/new/

https://reviews.llvm.org/D69930