[PATCH] D68195: [DAGCombiner] Peek through vector concats when trying to combine shuffles.

Amaury SECHET via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Nov 23 16:37:34 PST 2019


deadalnix added a comment.

In D68195#1757817 <https://reviews.llvm.org/D68195#1757817>, @lebedev.ri wrote:

> In D68195#1757811 <https://reviews.llvm.org/D68195#1757811>, @deadalnix wrote:
>
> > Alright, this is the first time I have to commit something with the new github process, and I have to admit, I do not know how to do it - or if I can do it at all. Running git llvm push ask me for a username and password, and my old one do not work. What's the next step for me here?
>
>
> Did you ever pushed anything to github before, to any other repository?
>  Did you clone https://github.com/llvm/llvm-project/ via HTTPS or SSH? (should be former!)
>  It is likely asking for your github login and password.
>
> You may *really* want to follow https://help.github.com/en/github/authenticating-to-github/creating-a-personal-access-token-for-the-command-line to create credentials with which you can *only* commit, but do nothing else


Hi,

Thanks for helping me out here. So I did commit on LLVM using the pre-github workflow (using git-svn), and did commit to github before in my own projects. I did not yet use the intersection of the two.

Here is what I'm getting when I'm trying to push that patch:

  $ git llvm push
  `git fetch https://github.com/llvm/llvm-project.git master` printed to stderr:
  From https://github.com/llvm/llvm-project
   * branch                    master     -> FETCH_HEAD
  Pushing 1 commit:
    0252f080c7c [DAGCombiner] Peek through vector concats when trying to combine shuffles.
  Username for 'https://github.com': deadalnix
  Password for 'https://deadalnix@github.com':
  `git push https://github.com/llvm/llvm-project.git 0252f080c7c01e7493c7d6c9bb9ed8701469c4a8:master` returned 128
  remote: Permission to llvm/llvm-project.git denied to deadalnix.
  fatal: unable to access 'https://github.com/llvm/llvm-project.git/': The requested URL returned error: 403

I tried to generate a token as suggested, and tried different permission settings for the token, including granting all permission to make sure there wasn't something I was missing, and I always get the same result.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68195/new/

https://reviews.llvm.org/D68195





More information about the llvm-commits mailing list