[PATCH] D70628: [Support] Enable file + line info in LLVM stack traces on Darwin.

[Don Hinton via Phabricator via llvm-commits]

hintonda added a comment.

This is awesome, thanks for working on it!

I pulled down your patch and built it, but am not getting expected results.  Did I miss something?

I just munged an existing test to force a failure and emit a stack trace, and got the following 
(I have a recent llvm-symbolizer in my path):

  /Users/dhinton/projects/llvm/llvm-project/llvm/unittests/Support/ErrorTest.cpp:394: Failure
  Death test: FailToHandle()
      Result: died but not with expected error.
    Expected: Failure value returned from cantFail wrapped call
  CustomError \{7\}x
  Actual msg:
  [  DEATH   ] Failure value returned from cantFail wrapped call
  [  DEATH   ] CustomError {7}
  [  DEATH   ] UNREACHABLE executed at /Users/dhinton/projects/llvm/llvm-project/llvm/include/llvm/Support/Error.h:713!
  [  DEATH   ]  #0 0x0000000109e65c9c (SupportTests+0x100759c9c)
  [  DEATH   ]  #1 0x0000000109e66229 (SupportTests+0x10075a229)
  [  DEATH   ]  #2 0x0000000109e63fb6 (SupportTests+0x100757fb6)
  [  DEATH   ]  #3 0x0000000109e687ac (SupportTests+0x10075c7ac)
  <snip>


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70628/new/

https://reviews.llvm.org/D70628