[PATCH] D70350: [DWARF] Allow cross-CU references of subprogram definitions

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

In D70350#1748673 <https://reviews.llvm.org/D70350#1748673>, @vsk wrote:

> @aprantl I think the patch is correct as-written, but not for the reasons I expected :). It would be incorrect to //not// share TU-local subprogram definitions, I think. That's because such a definition may be inlined into a different TU, in which case a call to it would still need to be described. I've added a test case to illustrate this. I've also updated the comment to clarify the new situation.


That's correct. Though I'll leave it up to @aprantl to acknowledge/agree with this & provide final approval/resolution/closure there.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70350/new/

https://reviews.llvm.org/D70350