[PATCH] D70318: Recover debug intrinsics when killing duplicate or empty basic blocks

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/SimplifyCFG.cpp:1268
+        if (!DBI1 || !DBI2 || !DBI1->isIdenticalToWhenDefined(DBI2)) {
+          while (isa<DbgInfoIntrinsic>(I1)) {
+            if (DbgVariableIntrinsic *DVI = dyn_cast<DbgVariableIntrinsic>(I1))
----------------
Does this get easier to read if you factor out the two while loops into a sub-lambda and give that a descriptive name?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70318/new/

https://reviews.llvm.org/D70318