[PATCH] D70508: Fix an offset underflow bug in DwarfExpression when describing small values with subregisters

Thu Nov 21 10:05:31 PST 2019

jyknight added a comment.

In D70508#1755232 <https://reviews.llvm.org/D70508#1755232>, @aprantl wrote:

> In D70508#1754479 <https://reviews.llvm.org/D70508#1754479>, @jyknight wrote:
>
> > The test dwarf-size-field-overflow.test now takes over 60 seconds to run, which seems quite excessive.
> >
> > Is there no way to test this in a less-expensive manner?
>
>
> I almost halved the number of iterations in 1b9ef. On my iMac Pro in Release+Asserts it's running in 1.18s wall clock time now. Note however that even before my change it was only taking ~5s. Were you measuring a debug build?

Yes, in debug mode.

Thanks -- it now takes 22 sec, which is better. (Before the first change, it took 12 sec).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70508/new/

https://reviews.llvm.org/D70508