[PATCH] D70497: [DBG] Teach DebugEntityHistoryCalculator about Kill instructions.

[Tom Weaver via Phabricator via llvm-commits]

TWeaver marked 4 inline comments as done.
TWeaver added inline comments.


================
Comment at: llvm/test/DebugInfo/X86/kill_instruction_doesnt_close_dbg_intrinsic_range.mir:20
+  
+  declare void @llvm.dbg.value(metadata, metadata, metadata) #1
+  
----------------
djtodoro wrote:
> The attributes are removed, so we can get rid of the `#N`.
thanks for the spot. removed.


================
Comment at: llvm/test/DebugInfo/X86/kill_instruction_doesnt_close_dbg_intrinsic_range.mir:22
+  
+  declare void @llvm.stackprotector(i8*, i8**) #2
+  
----------------
djtodoro wrote:
> This is unused here, so it can be deleted.
thanks for the spot. removed.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70497/new/

https://reviews.llvm.org/D70497