[PATCH] D70628: [Support] Enable file + line info in LLVM stack traces on Darwin.

[Lang Hames via Phabricator via llvm-commits]

lhames added a comment.

Looking for feedback on the approach before I go too much further with this. I was motivated to enable file + line info by Don Hinton's work in https://reviews.llvm.org/D70259 and https://reviews.llvm.org/D70263, where he attaches source location information certain calls to aid in debugging of error handling failures. I have a review out for an alternative scheme that produces full backtraces for error handling failures (see https://reviews.llvm.org/D70600), but the lack of file and line info in the traces is a drawback compared to Don's approach.

As for why we don't have this on Darwin already: I'm not sure whether we had support for it and lost it at some point, or just never had it. It looks like we experimented with other approaches a while back (e.g. _Unwind_Backtrace in https://reviews.llvm.org/D28265) but ultimately gave up.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70628/new/

https://reviews.llvm.org/D70628