[PATCH] D70606: LLD: CET shadow stack support on Windows

Fri Nov 22 14:43:25 PST 2019

penzn added inline comments.

================
Comment at: lld/MinGW/Options.td:105
 def: F<"nxcompat">;
+def: F<"cetcompat">;
 def: F<"pic-executable">;
----------------
mstorsjo wrote:
> FWIW, if you want the option to actually have any effect when passed to the mingw driver, you need a couple lines in MinGW/Driver.cpp (and a corresponding test in test/MinGW/driver.test).
Good point, thank you. That is intentional - I noticed that other MSVC security flags have no effect in MinGW driver.

There is a patch for GNU-compatible linker on Linux, [[ https://reviews.llvm.org/D59780 | D59780 ]], though I am not sure if we can simply wire those options to COFF implementation introduced here. The goal of this patch is to support the VS-compatible flag.

I might be wrong with my assumptions on MinGW driver, any clarification would be greatly appreciated.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70606/new/

https://reviews.llvm.org/D70606