[PATCH] D70616: [GlobalISel] CombinerHelper: Fix a bug in matchCombineCopy

Aditya Nandakumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 22 13:39:01 PST 2019


aditya_nandakumar added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp:87
+  if (!DstTy.isValid() || !SrcTy.isValid() || DstTy != SrcTy)
+    return false;
+
----------------
Do we want this method to also handle the case of Regclass to Regclass copies (without any LLTs)? If yes, looks like this early exits.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70616/new/

https://reviews.llvm.org/D70616





More information about the llvm-commits mailing list