[PATCH] D70461: [AIX] Emit TOC entries for ASM printing

[David Tenty via Phabricator via llvm-commits]

daltenty added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:1873
+            PPCAsmPrinter::getMCSymbolForTOCPseudoMO(MO)->getName(),
+            XCOFF::XMC_UA, XCOFF::XTY_ER,
+            TargetLoweringObjectFileXCOFF::getStorageClassForGlobal(GV),
----------------
DiggerLin wrote:
> we create a MCSectionXCOFF which has  symbol type "XCOFF::XTY_ER", You have a test case which the external symbol, I just wonder it not hit the assert in the function  MCSectionXCOFF construction?
> 
> assert((ST == XCOFF::XTY_SD || ST == XCOFF::XTY_CM) &&
>            "Invalid or unhandled type for csect.");
> 
I believe that is handled in the parent revision D70443


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70461/new/

https://reviews.llvm.org/D70461