[PATCH] D70598: [yaml2obj/obj2yaml] - Add support for SHT_LLVM_DEPENDENT_LIBRARIES sections.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/lib/ObjectYAML/ELFEmitter.cpp:947
+    OS.write('\0');
+    SHeader.sh_size += (Lib.size() + 1);
+  }
----------------
`()` can be omitted.


================
Comment at: llvm/test/tools/yaml2obj/ELF/llvm-deplibs-section.yaml:66
+Sections:
+  - Name: .deplibs
+    Type: SHT_LLVM_DEPENDENT_LIBRARIES
----------------
Align the values.


================
Comment at: llvm/tools/obj2yaml/elf2yaml.cpp:661
+  for (const uint8_t *I = Content.begin(), *E = Content.end(); I < E;) {
+    StringRef Lib((const char *)(I));
+    DL->Libs->emplace_back(Lib);
----------------
`(I)` -> `I`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70598/new/

https://reviews.llvm.org/D70598