[PATCH] D69665: [llvm-ar] Fix llvm-ar response file reading on Windows
Owen Reynolds via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Nov 22 09:31:11 PST 2019
gbreynoo updated this revision to Diff 230669.
gbreynoo added a comment.
- Pulled out the MatchFlagWithArg lambda expression into static function, and done the same with some code that handles hyphen removal.
- Added test cases to response.test.
- Removed the python call in response-utf8.test. I would prefer the file comparison but it should be sufficient to show the archive is functioning properly.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69665/new/
https://reviews.llvm.org/D69665
Files:
llvm/test/tools/llvm-ar/response-utf8.test
llvm/test/tools/llvm-ar/response.test
llvm/tools/llvm-ar/llvm-ar.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D69665.230669.patch
Type: text/x-patch
Size: 8740 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191122/b010ec1d/attachment.bin>
More information about the llvm-commits
mailing list