[PATCH] D70531: AMDGPU: Fix lit test checks with dag option

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 22 07:00:19 PST 2019


arsenm requested changes to this revision.
arsenm added inline comments.
This revision now requires changes to proceed.


================
Comment at: llvm/test/CodeGen/AMDGPU/llvm.amdgcn.mfma.ll:1300
+; GCN-DAG:             v_mov_b32_e32 [[ONE:v[0-9]+]], 1.0
+; GCN-DAG-COUNT-8:     global_load_dwordx4
+; GCN-DAG-COUNT-16:    v_accvgpr_write_b32 a{{[0-9]+}}, v{{[0-9]+}}
----------------
dstuttard wrote:
> rampitec wrote:
> > AFAIK DAG-COUNT does not work.
> Yes, you're right. It just wasn't triggering the check at all - hence passing.
> I'll re-submit with lots of GCN-DAG checks instead, unless you can think of a better way to do it.
Repeating -DAG doesn’t work either as far as I know. Might as well just generate this test 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70531/new/

https://reviews.llvm.org/D70531





More information about the llvm-commits mailing list