[PATCH] D70595: [TargetLowering] Allow constants with multiple uses

[David Stuttard via Phabricator via llvm-commits]

dstuttard added a comment.

In D70595#1756702 <https://reviews.llvm.org/D70595#1756702>, @RKSimon wrote:

> I'd like to see more of the regressions on other targets (x86 in particular) - in many cases this will cause a lot of extra constant pool entries.


Ok - I'' take a look at those and upload some patches.

I'm more than happy if this can be solved in a different way - the issue isn't an optimisation opportunity, it is actually causing a problem with the attached example due to the difference between checking isNegatibleForFree (and it syaing it is) and it then finding a problem in getNegatedExpression when it returns a different (and unexpected) result from a call to isNegatableForFree when handling an ISD::FMA.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70595/new/

https://reviews.llvm.org/D70595