[PATCH] D70595: [TargetLowering] Allow constants with multiple uses

[David Stuttard via Phabricator via llvm-commits]

dstuttard marked an inline comment as done.
dstuttard added a comment.

I've got some failures as a result of this change in X86 (haven't tried the other backends). I guess that the failures are probably due to the fneg propagation working better for constants - but I haven't investigated yet. There will need to be more test changes as a result of this change.
My question is - does the change look reasonable? If so I'll take a look at the lit regressions for other backends.



================
Comment at: llvm/test/CodeGen/AMDGPU/const-multiuse-tl.ll:1
+; ModuleID = 'foo-new.bc'
+source_filename = "foo.ll"
----------------
RKSimon wrote:
> dstuttard wrote:
> > lebedev.ri wrote:
> > > This test doesn't actually check anything.
> > Yes, spotted it just after I uploaded. It does now. It's really only testing that it doesn't assert.
> Is this reduced as much as possible (both in terms of instructions and metadata)?
I've attempted to reduce it as much as possible - I did attempt to reduce it further but that stopped the problem occurring.
I might be able to reduce the metadata more.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70595/new/

https://reviews.llvm.org/D70595