[PATCH] D70437: [AArch64][SVE] Implement shift intrinsics

[Sander de Smalen via Phabricator via llvm-commits]

sdesmalen added a comment.
Herald added a reviewer: efriedma.

Two small comments, but overall looks good!



================
Comment at: llvm/include/llvm/IR/IntrinsicsAArch64.td:835
+                 LLVMMatchType<0>,
+                 llvm_i32_ty],
+                [IntrNoMem]>;
----------------
If this is an immediate, please add `ImmArg<OpNo>` to the list of properties.


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:671
   setOperationAction(ISD::INTRINSIC_WO_CHAIN, MVT::Other, Custom);
+  setOperationAction(ISD::INTRINSIC_WO_CHAIN, MVT::i8, Custom);
+  setOperationAction(ISD::INTRINSIC_WO_CHAIN, MVT::i16, Custom);
----------------
Given that we need this for some SVE instructions, perhaps enclose it in `if (Subtarget->isSVE())` ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70437/new/

https://reviews.llvm.org/D70437