[PATCH] D70590: [Examples] Exclude ExampleIRTransforms from ALL if examples are disabled.

Andrzej Warzynski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 22 04:07:09 PST 2019


andwar added inline comments.


================
Comment at: llvm/examples/IRTransforms/CMakeLists.txt:7
 
+# Do not include examples in "all" target. Also excludes it from the install
+# list.
----------------
[nit] Could you add a comment explaining `why` this is needed? Currently it says `what` is being done, but that's clear from the code. This could useful to our future selves.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70590/new/

https://reviews.llvm.org/D70590





More information about the llvm-commits mailing list