[PATCH] D70072: [ARM] Improve codegen of volatile load/store of i64
    Eli Friedman via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Thu Nov 21 16:37:54 PST 2019
    
    
  
efriedma added inline comments.
================
Comment at: llvm/lib/Target/ARM/ARMISelDAGToDAG.cpp:1279
+    int RHSC;
+    if (isScaledConstantInRange(N.getOperand(1), 1 << Shift, -128, 128, RHSC)) {
+      Base = N.getOperand(0);
----------------
Are you sure this range computation is right?  The range should be multiples of 4 from -1020 to 1020.
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70072/new/
https://reviews.llvm.org/D70072
    
    
More information about the llvm-commits
mailing list