[PATCH] D70510: [PGO][PGSO] Add an optional query type parameter to shouldOptimizeForSize.
    Hiroshi Yamauchi via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Thu Nov 21 14:48:09 PST 2019
    
    
  
yamauchi added a comment.
For example, we could retain the existing behavior (return true only for cold code and the existing call sites of shouldFuncOptimizeForSize) while adding new callers of shouldOptimizeForSize by changing shouldOptimizeForSizeImpl to always false for the "QueryType == PGSOQueryType::Other" case. An alternative would be to combine addition of new callers and behavior changes.
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70510/new/
https://reviews.llvm.org/D70510
    
    
More information about the llvm-commits
mailing list