[PATCH] D70450: [AArch64] Teach Load/Store optimizier to rename store operands for pairing.

[Florian Hahn via Phabricator via llvm-commits]

fhahn marked an inline comment as done.
fhahn added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64LoadStoreOptimizer.cpp:845
+
+// Apply Fn to all sub and super registers of Reg and Reg itself.
+template <typename RetT>
----------------
fhahn wrote:
> paquette wrote:
> > Is this comment accurate?
> > 
> > Maybe I'm misreading the function here, but it looks like you don't necessarily apply the function to all of the super registers. In the first loop, you can return before hitting the second loop, no?
> Yep, we exit when the result of Fn evaluates to true. This is a bit weird, but was required to be usable in both cases..... An iterator would be nicer here as well.
I've added sub_and_superregs_inclusive and phys_regs_and_masks iterators in a dependent patches.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70450/new/

https://reviews.llvm.org/D70450