[PATCH] D70095: [PGO][PGSO] DAG.shouldOptForSize part.

[Hiroshi Yamauchi via Phabricator via llvm-commits]

yamauchi added a comment.

In D70095#1754675 <https://reviews.llvm.org/D70095#1754675>, @RKSimon wrote:

> Does WebAssembly still need updating ?


I somehow missed the WebAssembly comment. Thanks for reminding.

I think we can remove WebAssemblyDAGToDAGISel::ForCodeSize and the hasOptSize call.
Three reasons:
(1) ForCodeSize is not used,
(2) We can't call DAG.shouldOptForSize there because DAG isn't initialized at that point (if we want to query this at a block granularity, it wouldn't make sense to call it there to begin with.)
(3) Removing it would minimize confusions, I think, in case we want to implement size optimizations here for WebAssembly in the future (in which case, we could follow the other targets code and use DAG.shouldOptForSize.)
Of course, we could alternatively leave it as is, and no update needed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70095/new/

https://reviews.llvm.org/D70095